Fixing concurrency crash with register device token#992
Open
franco-zalamena-iterable wants to merge 1 commit intomasterfrom
Open
Fixing concurrency crash with register device token#992franco-zalamena-iterable wants to merge 1 commit intomasterfrom
franco-zalamena-iterable wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✏️ Description
Root Cause
The SDK was using a non-thread-safe
HashMapfordeviceAttributes, which causedConcurrentModificationExceptioncrashes when the map was modified from one thread while another thread was iterating over it during device token registration.Why This Happens
The crash occurred in the following scenario:
registerDeviceToken(), which iterates overdeviceAttributesto copy them into the registration payloadsetDeviceAttribute()orremoveDeviceAttribute(), modifying theHashMapConcurrentModificationExceptionAccording to the crash stack trace from issue #642:
HashMapis not thread-safe and explicitly throwsConcurrentModificationExceptionwhen concurrent modification is detected during iteration. This is a fail-fast mechanism to prevent data corruption.Fix
Replaced
HashMap<String, String>withConcurrentHashMap<String, String>for thedeviceAttributesfield.ConcurrentHashMapis specifically designed for concurrent access and provides thread-safety without explicit synchronization.Fixes
References